Loosen unnecessary restrictions on the body option
#521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/error.js
Outdated
| body.push(chunk); | ||
| }).on('end', () => { | ||
| res.end(Buffer.concat(body).toString()); | ||
| }); |
There was a problem hiding this comment.
Use get-stream here for simplicity
test/error.js
Outdated
| @@ -54,17 +63,27 @@ test('dns message', async t => { | |||
|
|
|||
| test('options.body error message', async t => { | |||
| const err = await t.throws(got(s.url, {body: {}})); | |||
| t.regex(err.message, /The `body` option must be a stream\.Readable, string or Buffer/); | |||
| t.is(err.message, 'The `body` option must be a stream.Readable, string or Buffer'); | |||
There was a problem hiding this comment.
We should change all of the t.throws assertions to the new format. Should not be done in this PR though. Just a note to myself.
There was a problem hiding this comment.
Ok, so after this gets merged I'll do another PR for that.
test/error.js
Outdated
| this.a = 123; | ||
| } | ||
|
|
||
| const {body} = (await got(`${s.url}/body`, {body: new CustomObject(), json: true})); |
There was a problem hiding this comment.
You don't need parens around await
There was a problem hiding this comment.
Yup. Forgot because before I did const body = (...).body then I used const { body } = ... :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #381