Ignore JSON option when using got.stream()

[szmarczak]

No description provided.

[sindresorhus]

How is this related to the JSON change and what does read-only mean here?

[szmarczak]

AFAIK form option is converted to body option here. read-only means the stream is no longer writable.

The only related thing is that I've changed the messages about streams.

[szmarczak]

I've just changed the sentence to make things clearer. The behaviour of form option remains the same.

[sindresorhus]

But you changed the meaning. Previously it said that the option cannot be used with got.stream() at all. Now you're saying that it can, but that the stream will be read-only. If this is true, can you point to a test proving that?

[szmarczak]

Previously it said that the option cannot be used with got.stream() at all.

Yeah, but practically it wasn't true.

can you point to a test proving that?

Sure :)

[szmarczak]

Here you go:

got/test/stream.js

Lines 62 to 66 in b504346

	test('throws on write to stream with body specified', t => {
	t.throws(() => {
	got.stream(s.url, {body: 'wow'}).end('wow');
	}, 'Got\'s stream is not writable when the `body` option is used');
	});

See? I hope it proves it :)

[sindresorhus]

👍 Great :)