Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some 💩 code (by me) like this:
Or this:
Which was hard to maintain and read.
Main reason for this code - there was two different arguments for
get
function - first contains request options (as object or as string) and other gets got options.This logic was replaced by merging
url
andopts
arguments ingot
function into one. Because (on redirect) we can reassign parsed request options.In the process
redirect
event was fixed - it was emitting oldopts
that was not from redirect itself.#72 was fixed by reassing
path
topathname
(ifpathname
is present). I don't know, if this is right thing to do, but because of difference inhttp.request
andurl.format
+url.parse
we have to normalise options or use anotherurl.format
implementation.//cc @sindresorhus @sindresorhus @kevva