This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the task into modular chunks that are more easily tested.
Aside form being split up, the actual implementation logic is basically the same.
I think the goal here should be to test the grunt-recess task itself, not the Grunt API (which is already well tested) and not the RECESS library for the same reason. As such, I've focussed on adding some tests that check what is passed to the RECESS library from the task.
The tests themselves are a bit thin on the ground- the main work here was the refactor than enables the tests to actually work. Further tests can be subsequently added with ease.
For backwards compatibility, I've left the
recess
task in theGruntfile
so the output of the original 'tests' can still be seen. However, these aren't run as part of the Travis build (FYI, I added a Travis build file).Once this is done I'll look at adding in the
recessrc
config option I discussed in the gulp-recess PR. Before that though, I want to make sure any changes are testable.