Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping #29

Closed
sindresorhus opened this issue Apr 24, 2013 · 1 comment
Closed

Escaping #29

sindresorhus opened this issue Apr 24, 2013 · 1 comment

Comments

@sindresorhus
Copy link
Owner

I discovered this lib https://github.com/jimmycuadra/shellwords today which escapes commands. I don't think exec() escapes its input so this could be useful.

Is there any downsides to just escaping by default? Or should escaping lib just be mentioned in the readme?

@jimmycuadra do you know?

@jimmycuadra
Copy link

Not sure what the context is here, but I'm not sure it's desirable to escape all strings you would pass to exec. Try it with some commands that have quotes in them and see if they work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants