Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.0.0 update to pass the source file path to SVGO uses the wrong key #61

Closed
the-codery opened this issue Jun 1, 2019 · 3 comments · Fixed by #63
Closed

6.0.0 update to pass the source file path to SVGO uses the wrong key #61

the-codery opened this issue Jun 1, 2019 · 3 comments · Fixed by #63

Comments

@the-codery
Copy link

Plugin passes the key srcPath but SVGO looks for path
See change made for #59

Relevant code in prefixIds file is:

    } else if (extra && extra.path && extra.path.length > 0) {
        var filename = path.basename(extra.path);
        prefix = filename;
    }
@thisischrisj
Copy link

Can I submit a pull request to fix this?

@sindresorhus
Copy link
Owner

Yes

@tustin2121
Copy link
Contributor

This is still broken.

tustin2121 added a commit to tustin2121/grunt-svgmin that referenced this issue Jul 30, 2020
@tustin2121
Fixing prefix path issue sindresorhus#61
d24cc10
@tustin2121 tustin2121 mentioned this issue Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix filename prefix issue tustin2121/grunt-svgmin
4 participants
@sindresorhus @tustin2121 @thisischrisj @the-codery