Fix behavior for matching paths outside cwd #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximelkin
force-pushed
the
fix_outside_cwd_match
branch
from
d9263cb
to
a799e79
Compare
|
Should be logic of detecting absolute/relative path go in minimatch instead? |
|
Sorry, seems I missed this one. |
|
Can you explain exactly what the breaking change is? What used to work and will no longer work (from a user's perspective)? |
|
I will return to PR in two weeks |
maximelkin
changed the title
|
Bump |
|
Got stuck at minimatch.match('/A/B/C/d.js', '!/**/test.js') -> false
minimatch.match('/A/C/test.js', '!/A/B/**/*.js') -> false |
replace **/**/ to **/ in test
|
Got what, tried to exclude from empty set of files |
fix tests with ! only (not matches anything and whats good) fix behaviour checking test for !** test also comments
maximelkin
changed the title
|
@sindresorhus described changes in test cases, most of them failing on old version |
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85 (not sure, maybe #87 too)
Here breaking changes:
Old behavior:
all paths, which is outside of current working directory, should be matched only by absolute path glob
New behavior:
you can match dirs outside current working dir
if you want match globally - start glob pattern with /
Removed test "should filter relative paths that leave current directory tree", because of breaking change
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor