Test for require. #102
Closed
Test for require. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| beforeEach(function(){ | ||
| tempFile = temp.path({dir:process.cwd(), suffix: '.js'}); | ||
| tempFileBaseName = path.basename(tempFile); | ||
| fs.closeSync(fs.openSync(tempFile, 'w')); |
There was a problem hiding this comment.
More succinct to just use https://github.com/sindresorhus/temp-write
There was a problem hiding this comment.
I just want an empty file in the current working directory. temp-write seems to write the the tmp-directory of the running OS.
Importing the file using the whole path works before 044d6b6 so I don't feel that the test would cover the case I was having trouble with.
|
@sindresorhus |
|
Looks good. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for functionality introduced in 044d6b6
A temporary .js-file is created before each test and removed afterwards. The tests will try to import the temporary file with or without the ./-prefix and also once when the js-file is missing.
The tests are written in a new js-file in order to have before and afterEach-methods. If you prefer to have them in the test.js-file I can move them there.