Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for compression level #9

Closed
darsain opened this issue Feb 5, 2014 · 4 comments
Closed

Option for compression level #9

darsain opened this issue Feb 5, 2014 · 4 comments

Comments

@darsain
Copy link

darsain commented Feb 5, 2014

... would be nice :)

@ctalkington
Copy link

@sindresorhus with zip-stream you can just allowing passing options as second arg and pass it directly to zip-stream then people can control a number of options listed here..

https://github.com/ctalkington/node-zip-stream#instance-options

@sindresorhus
Copy link
Owner

jszip which this plugin uses has a compressions option, but by default it's no compression or deflate. You can also supply your own compressions method. Though there don't seem to exist any custom ones at this time. In addition I don't see the point in having an option just to toggle compression. So for now this is not possible.

@darsain
Copy link
Author

darsain commented Mar 28, 2014

Dunno how others, but I consider a zip plugin that doesn't compress broken. Are you sure you want to just close this and throw it over your shoulder? :/ Without compression this is basically gulp-tar.

At least leave this open as a reminder to look/wait for a library that supports it, or zip-stream gets fixed.

@sindresorhus
Copy link
Owner

@darsain It does compress. it's just not configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants