Reimplement a synchronous method - Fixes #13 #14
Conversation
index.js
Outdated
| module.exports.v6 = () => internalIp('v6'); | ||
| module.exports.v4 = () => internalIp('v4'); | ||
| function sync(family) { | ||
| const result = defaultGateway[family].sync(); |
There was a problem hiding this comment.
you need to wrap this line in a try...catch and return the defaults in case of error.
index.js
Outdated
|
|
||
| return Boolean(ret); | ||
| }); | ||
| function match(gateway, family) { |
There was a problem hiding this comment.
maybe findIp might be a better name.
There was a problem hiding this comment.
from line 16 // Look for the matching interface in all local interfaces - that's why I chose the name. doesn't much matter to me what you think it should be, happy to change it, but I thought it was appropriate given that comment
There was a problem hiding this comment.
Yeah, I still think findIp is more appropriate. The matching is only part of the process.
There was a problem hiding this comment.
aye, will change
| const prefix = ipaddr.parse(addr.netmask).prefixLengthFromSubnetMask(); | ||
| const net = ipaddr.parseCIDR(`${addr.address}/${prefix}`); | ||
|
|
||
| if (net[0].kind() === gatewayIp.kind() && gatewayIp.match(net)) { |
There was a problem hiding this comment.
just noticed this: could you add a check for net[0] here, e.g. if (net[0] && net[0].kind()?
There was a problem hiding this comment.
this is a direct copy paste from the code as it presently is in master. mentioning only to confirm that you want to piggy back on this PR for the change
There was a problem hiding this comment.
right, I can fix that later myself, no need to do it here.
sindresorhus
changed the title
This PR makes use of a recent update to
default-gatewaywhich provides synchronous methods, to reimplement sync support in this module.