New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AIX support again #25
Conversation
package.json
Outdated
"openbsd", | ||
"sunos", | ||
"win32" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use os
in any packages. It's buggy and I don't want to prevent a consumer of this package to support different platforms just because they depend on internal-ip
. Runtime checks are better with optionalDependencies
is a better choice.
But it doesn't matter. default-gateway
has os
, so this package doesn't need it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, os
removed.
Went ahead and removed |
Will this require a major release of |
It is breaking only for AIX users which should represent like 0.00001% of the users (if any at all). Your decision. |
See silverwind/default-gateway#10. In summary, I had a
os
-locked optional native dependency to support AIX but it turns out npm has a bug where it will ignoreos
in some cases, leading to gyp error spam on commands likenpm ci
andnpm install --force
.Dropped the platform again for this reason until someone provides a pure-js implementation. Ideally, this should be released as semver-major.