Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AIX support again #25

Merged
merged 3 commits into from Feb 23, 2019
Merged

Remove AIX support again #25

merged 3 commits into from Feb 23, 2019

Conversation

silverwind
Copy link
Collaborator

@silverwind silverwind commented Feb 22, 2019

See silverwind/default-gateway#10. In summary, I had a os-locked optional native dependency to support AIX but it turns out npm has a bug where it will ignore os in some cases, leading to gyp error spam on commands like npm ci and npm install --force.

Dropped the platform again for this reason until someone provides a pure-js implementation. Ideally, this should be released as semver-major.

package.json Outdated
"openbsd",
"sunos",
"win32"
],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use os in any packages. It's buggy and I don't want to prevent a consumer of this package to support different platforms just because they depend on internal-ip. Runtime checks are better with optionalDependencies is a better choice.

But it doesn't matter. default-gateway has os, so this package doesn't need it anyway.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, os removed.

@sindresorhus sindresorhus changed the title remove AIX support again Remove AIX support again Feb 22, 2019
@silverwind
Copy link
Collaborator Author

silverwind commented Feb 23, 2019

Went ahead and removed os in default-gateway too. It's better that way because there is no issue with installing on unsupported platforms like AIX. It will allow dependants to gracefully treat the thrown Unsupported Platform error which is better than failing the installation entirely.

@sindresorhus
Copy link
Owner

Will this require a major release of internal-ip?

@silverwind
Copy link
Collaborator Author

silverwind commented Feb 23, 2019

It is breaking only for AIX users which should represent like 0.00001% of the users (if any at all). Your decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants