Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the check case-insensitive on Windows #10

Merged

Conversation

chrisblossom
Copy link
Contributor

Because this package relies on path-is-inside which treats windows as case-insensitive, this module should probably do the same otherwise isPathInside('C:\a\b\c', 'c:\a\b\c') === true.

index.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title make windows paths case-insensitive Make the check case-insensitive on Windows Jul 3, 2019
@sindresorhus sindresorhus merged commit 26a5cf1 into sindresorhus:master Jul 5, 2019
@sindresorhus
Copy link
Owner

Thanks for fixing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants