You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this is probably a bit subjective but the fact that the host option defaults to localhost actually cost me a couple of hours debugging right now.
I accidentally set await isPortReachable(22, { ipv4 }) and hence it would never resolve until I spotted the error that I had not set the host option appropriately.
Anyway, I think a better default would be to throw in case no host is set, as it means the function can't proceed.
The text was updated successfully, but these errors were encountered:
TimDaub
changed the title
"localhost" as default can lead to long debugging sessions
"localhost" as default for host option can lead to long debugging sessions
Jan 8, 2021
馃憢馃徏 hey,
this is probably a bit subjective but the fact that the
host
option defaults tolocalhost
actually cost me a couple of hours debugging right now.I accidentally set
await isPortReachable(22, { ipv4 })
and hence it would never resolve until I spotted the error that I had not set thehost
option appropriately.Anyway, I think a better default would be to throw in case no
host
is set, as it means the function can't proceed.The text was updated successfully, but these errors were encountered: