Fix false-positive when the <!Entity> tag contains markup
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kup inside an <Entity> tag
sindresorhus
requested changes
Jan 3, 2020
|
The PR title should say what it fixes more clearly. And you should use I would recommend reading https://github.com/tiimgreen/github-cheat-sheet#readme |
eluisfonseca
changed the title
sindresorhus
changed the title
<!Entity> tag contains markup
|
This looks great now. Thanks for all your hard work on this PR 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Fixes isSvg returning false for valid svg, whenever they included markup inside an tag
It now searches for <!Entity> tags and clears them of markup, before applying the usual regex.
Also added an svg with an appropriate example to the valid svg tests.