Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Regex to handle DTD markup declarations #9

Merged
merged 2 commits into from
Nov 4, 2016
Merged

Update Regex to handle DTD markup declarations #9

merged 2 commits into from
Nov 4, 2016

Conversation

kraftner
Copy link
Contributor

Fixes #8

@sindresorhus
Copy link
Owner

So not to make the regex totally unreadable, I think it would be better to just strip any [<!ENTITY [\s\S]*>] from the string before doing the existing regex check.

@kraftner
Copy link
Contributor Author

Looking at the Wikipedia Article linked in the corresponding issue I have the impression that there are quite some more possible values than just <!ENTITY ... > this is why I kept it as general as possible.

@sindresorhus sindresorhus merged commit 4e69174 into sindresorhus:master Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants