Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Es-bundle getting imported on Vercel #23

Closed
privatenumber opened this issue Aug 25, 2020 · 3 comments
Closed

Es-bundle getting imported on Vercel #23

privatenumber opened this issue Aug 25, 2020 · 3 comments

Comments

@privatenumber
Copy link
Sponsor

This was happening via nuxt/http which uses ky and a copied implementation of ky-universal.

I figured this should also be fixed here too.

nuxt/http#121

@sindresorhus
Copy link
Owner

I don't have all the context. What's to fix here? It sounds like a bug in the "Vercel bundle importer". ky-universal is working fine everywhere else.

@sholladay
Copy link
Collaborator

This seems like some kind of proprietary environment issue. I see nothing that justifies why this logic belongs in Ky specifically. If anything, it sounds like it affects all node-fetch users and should be fixed there. But ultimately, it's probably a wider issue with the module loader.

@privatenumber
Copy link
Sponsor Author

privatenumber commented Aug 26, 2020

Those are fair points.
We landed a fix in nuxt/http--which I thought could also be applied here--, but the true fix might belong in Vercel's module loader.

I'll investigate further and re-open if I see anything actionable on ky's end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants