Fix the NormalizedOptions.headers TypeScript type #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholladay
changed the title
|
Sorry. I missed this. Looks good 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240
This PR removes a vestigial part of our
NormalizedOptionsTypeScript interface that is no longer necessary and causes issues for TypeScript users who pass theheadersoption as a plain object (as opposed to a Headers instance) and then receive it inside of a hook. The definition ofheadersnow comes fromRequestInit.For context, in older versions of Ky, we aggressively normalized the options object passed by the user before running any hooks. However, newer versions of Ky try to avoid such normalizations in favor of constructing a Request instance and passing that around, as it does a lot of the work for us, including normalizing the headers.