Fix aborting when onDownloadProgress throws an exception
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this hangs the test runner after indicating failure
Seems like https://bugs.chromium.org/p/chromium/issues/detail?id=817687 was not completely fixed?
sindresorhus
changed the title
onDownloadProgress throws uncatchable exception
sindresorhus
approved these changes
Dec 19, 2020
szmarczak
approved these changes
Dec 19, 2020
sholladay
approved these changes
Dec 19, 2020
sholladay
changed the title
onDownloadProgress throws uncatchable exceptiononDownloadProgress throws an exception
|
LGTM. One nice thing about this is that we could now allow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See commit messages.)
For instance, the catch block in the example in the README would not catch the AbortError if an onDownloadProgress callback were passed to ky.
I'm not entirely sure about the Chromium bug. With the patches applied in my project that uses ky, I could get Firefox to throw an AbortError, so I suspect https://bugs.chromium.org/p/chromium/issues/detail?id=817687 is not fully fixed.