Add `request` and `options` to `HTTPError` #309

jabuj · 2020-12-14T07:47:02Z

Fixes #287

sindresorhus · 2020-12-19T16:37:35Z

You also need to update the TS doc comment and the readme.

index.d.ts

index.test-d.ts

index.js

jabuj · 2021-01-04T04:01:28Z

Why is it displaying "Changes requested"? I've added all of the suggestions in the last commit it seems

index.d.ts

sholladay · 2021-01-04T06:53:56Z

index.d.ts needs to be synced with the readme, as Sindre mentioned, but otherwise LGTM.

jabuj added 2 commits December 14, 2020 17:45

Added request and options to HTTPError

8f5e67f

Fixed type tests for new HTTPError constructor

74f633c

sindresorhus requested changes Dec 19, 2020

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

index.test-d.ts Outdated Show resolved Hide resolved

sindresorhus changed the title ~~Added request and options to HTTPError~~ Add request and options to HTTPError Dec 19, 2020

dan-lee reviewed Dec 21, 2020

View reviewed changes

index.js Outdated Show resolved Hide resolved

jabuj added 2 commits January 4, 2021 05:58

Fixed typos, readme and tsdoc comments

f923167

Added a note in readme on TimeoutError

089cbac

sindresorhus reviewed Jan 4, 2021

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

Update readme.md

c93a8c7

jabuj and others added 3 commits January 8, 2021 14:06

Fixed jsdoc

e20caa9

Update index.d.ts

7ed37b1

Update readme.md

cebd601

sindresorhus merged commit 519d17e into sindresorhus:master Jan 8, 2021

Provide feedback