Improve HTTPError messages #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe: |
Done. |
|
@sindresorhus I fixed the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a clearer error message to the user when an
HTTPErroroccurs, by adding a description and showing both the status code and status text, when available.Perhaps the best example of how this helps is where the response has an unusual status code, such as 0, but there is no status text, as is the case when HTTP/2 is being used.
Before:
After:
Happy to bikeshed the phrasing. Could change "failed with status" to "failed with response status", for example. Also on the fence about "an unknown error" vs "an unknown status" vs "an unknown response error", etc.