Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing hook method types for TypeScript #353

Merged
merged 3 commits into from May 31, 2021

Conversation

Qwerios
Copy link
Contributor

@Qwerios Qwerios commented May 31, 2021

Since version 0.28 the types exported by ky seem to have been reduced. Our codebase relies on ky hooks and we used to be able to import the hook method types from ky in TypeScript.

import { AfterResponseHook, BeforeRequestHook } from 'ky';

This PR adds the missing exports for the hook methods back to the index including the new retry hook method.

@sindresorhus sindresorhus merged commit 8fc2f22 into sindresorhus:main May 31, 2021
@Qwerios
Copy link
Contributor Author

Qwerios commented May 31, 2021

Thank you very much for the rapid response, merge and release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants