Add beforeError hook
#417
Merged
Add beforeError hook
#417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linting is not passing. Make sure you always run |
|
It needs to be documented in the readme too. |
|
@sindresorhus I see this error which is not related to my changes: any idea what to be done about it? |
|
@sindresorhus Any update in this? |
source/types/hooks.ts
Outdated
|
|
||
| /** | ||
| Called with `HTTPError` instance. The error is passed to the hook right before it's thrown. | ||
| This is especially useful when you want to have more detailed errors. |
There was a problem hiding this comment.
Readme and TS docs should be in sync.
readme.md
Outdated
| Type: `Function[]`\ | ||
| Default: `[]` | ||
|
|
||
| This hook enables you to modify the HTTPError right before it is thrown. The hook function receives `HTTPError` as argument and should return instance of HTTPError. |
There was a problem hiding this comment.
Suggested change
| This hook enables you to modify the HTTPError right before it is thrown. The hook function receives `HTTPError` as argument and should return instance of HTTPError. | |
| This hook enables you to modify the `HTTPError` right before it is thrown. The hook function receives `HTTPError` as argument and should return instance of `HTTPError`. |
readme.md
Outdated
| await ky('https://example.com', { | ||
| hooks: { | ||
| beforeError: [ | ||
| (error) => { |
There was a problem hiding this comment.
Suggested change
| (error) => { | |
| error => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412