-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix abortions between retries #433
Conversation
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
I still need to modify the tests before this is ready |
Before, abortions would essentially be postponed until Should we replicate the fetch abortion error that was previously thrown or continue rolling our own custom error message? |
I think we should try to replicate it. See how we did it here: https://github.com/sindresorhus/p-retry/pull/59/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R38-R40 |
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Can you add a TODO comment about using |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
… between-retries
This is still marked as draft, is there any pending work? |
I don't think there's anything left to do but the build is failing and I don't know why |
Follow what the error says? |
There's a new error now: https://github.com/sindresorhus/ky/runs/7428874132?check_suite_focus=true |
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Should be working now, try re-running CI |
Thanks :) |
#390