Fixes #312 Add typed json response #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a type test to prove that your change actually resolves the issue. |
|
@sindresorhus I'm not quite sure how to do this. I don't see a way to automatically check the type when they are gone at runtime. Sorry if I overlook something right now. 😅 |
|
@sindresorhus Sorry to bother you, but I can't continue without an answer to my previous question. |
|
You should test at compile-time. The Ky tests are in TypeScript, so you can use type assertions. For example, using https://github.com/mmkal/ts/tree/master/packages/expect-type |
|
@sindresorhus I have added a type check to the tests with the mentioned library. Could you please have a look at my changes? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
to fix the issue, I implemented an axios like solution with an extended response object. With this solution, there should be no breaking changes either.
Fixes #312