Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export BeforeRetryState from types/hooks #442

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

cristobal
Copy link
Contributor

@cristobal cristobal commented Jun 23, 2022

The BeforeRetryState is the only type not exported from types/hooks.

Background
We are doing an upgrade to TS 4.7, in our code we were importing the BeforeState directly like this:

import { BeforeRetryState } from 'ky/distribution/types/hooks';

However after upgrading to TS 4.7, were can no longer can import the BeforeRetryState type directly:
Screenshot 2022-06-23 at 12 17 58
And since it's not export the the following does not work either:
Screenshot 2022-06-23 at 12 18 25

So we want the BeforeRetryState too also be exported, so that we can import it directly e.g.:

import { BeforeRetryState } from 'ky';

BeforeRetryState is the only type not exported from types/hooks.
@sindresorhus sindresorhus merged commit e4077b9 into sindresorhus:main Jun 23, 2022
@cristobal cristobal deleted the patch-1 branch June 23, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants