Don't return empty string for .json() if Transfer-Encoding is chunked #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #463
Here is some relevant documentation about the
Transfer-Encoding
header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Transfer-Encoding , specifically when achunked
value is set for that header:This is in contradiction to an implicit assumption seemingly made in #459 that a
Content-Length
header will always be set to some non-zero value if there is content in the response body.The logic change in this PR returns a blank string for
.json()
only if theContent-Length
header is'0'
or missing (per #459) AND if there is not aTransfer-Encoding
header with a value ofchunked
.The test added in this PR sets a
Transfer-Encoding: chunked
header (and omits aContent-Length
header) via the following setup, which writes to the response in chunks rather than all at once: