-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importing index.ts in readme.md deno example #499
Conversation
for deno I think it's better to use the more idiomatic index.ts export from https://deno.land
Did you test that this works? |
readme.md
Outdated
@@ -110,7 +110,7 @@ console.log(json); | |||
If you are using [Deno](https://github.com/denoland/deno), import Ky from a URL. For example, using a CDN: | |||
|
|||
```js | |||
import ky from 'https://esm.sh/ky'; | |||
import ky from "https://deno.land/x/ky/source/index.ts"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single-quotes
I would also prefer to keep the esm.sh example below the new Deno.land one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test that this works?
😬 sorry about that! does the deno.land publish work at all? couldn't find a working path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. I don't use Deno.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks, it doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point, they changed the backend architecture of deno.land so that in order to publish new releases of Ky on there, we have to set up a webhook on our repository, whereas before they had some magic to watch for GitHub releases automatically.
We just need to set up this webhook and then importing from deno.land will work again.
single quotes
for deno I think it's better to use the more idiomatic index.ts export from https://deno.land