fix: return types should include undefined #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `from` or `to`, the methods can return `undefined` but the types were not indicating that.
|
Thanks :) |
Repository owner
deleted a comment from
sh471
Jan 17, 2023
Repository owner
deleted a comment from
sh471
Jan 17, 2023
Repository owner
deleted a comment from
sh471
Jan 17, 2023
Repository owner
deleted a comment from
sh471
Jan 17, 2023
Repository owner
deleted a comment from
sh471
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
fromorto, the methods can returnundefinedbut the types were not indicating that.All tests pass.
This is the first time I am contributing to an open source package. I probably forgot a few things. Just let me know and I will happily comply. :)
Fixes #14