Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly skip plus-prefixed URLs #21

Merged
merged 5 commits into from
Dec 9, 2018
Merged

Correctly skip plus-prefixed URLs #21

merged 5 commits into from
Dec 9, 2018

Commits on Dec 5, 2018

  1. Fix skip prefixed URLs 

    How: Adding a negative lookbehind on the main RegEx to ignore URLs preceded by
Why: Negative lookbehinds seem to be supported since Node v6 with the  flag (ref: https://node.green/#ES2018-features--RegExp-Lookbehind-Assertions) and should also be supported in ES2019 (ref: https://tc39.github.io/ecma262/).
    Pedro Pinto committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    5021db1 View commit details
    Browse the repository at this point in the history

  2. Tweak Git URLs test name

    Pedro Pinto committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    2ee8caa View commit details
    Browse the repository at this point in the history

  3. Update README file to include a compatibility note regarding look-beh… 

    …ind assertions
    Pedro Pinto committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    e4eddb4 View commit details
    Browse the repository at this point in the history

  4. HOTFIX: Wrong syntax on RegEx 

    Even though tests were fine
    Pedro Pinto committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    75f6929 View commit details
    Browse the repository at this point in the history

  5. Remove Node v6 from Travis config file

    Pedro Pinto committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    06f9bf0 View commit details
    Browse the repository at this point in the history