Improve robustness of options.type (#10)

sindresorhus · Jun 6, 2022 · 6afde95 · 6afde95
1 parent 42df341
commit 6afde95
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -10,14 +10,14 @@ const typeMappings = {
 };
 
 function checkType(type) {
-	if (type in typeMappings) {
+	if (Object.hasOwnProperty.call(typeMappings, type)) {
 		return;
 	}
 
 	throw new Error(`Invalid type specified: ${type}`);
 }
 
-const matchType = (type, stat) => type === undefined || stat[typeMappings[type]]();
+const matchType = (type, stat) => stat[typeMappings[type]]();
 
 const toPath = urlOrPath => urlOrPath instanceof URL ? fileURLToPath(urlOrPath) : urlOrPath;
 

diff --git a/test.js b/test.js
@@ -24,6 +24,11 @@ test('async', async t => {
 		message: 'Invalid type specified: rainbows',
 	});
 
+	await t.throwsAsync(locatePath(['fixture'], {type: 'toString'}), {
+		instanceOf: Error,
+		message: 'Invalid type specified: toString',
+	});
+
 	await t.throwsAsync(locatePath(['fixture'], {type: 1}), {
 		instanceOf: Error,
 		message: 'Invalid type specified: 1',
@@ -56,6 +61,13 @@ test('sync', t => {
 		message: 'Invalid type specified: rainbows',
 	});
 
+	t.throws(() => {
+		locatePathSync(['fixture'], {type: 'toString'});
+	}, {
+		instanceOf: Error,
+		message: 'Invalid type specified: toString',
+	});
+
 	t.throws(() => {
 		locatePathSync(['fixture'], {type: 1});
 	}, {