use weak for supperior handling #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like Travis is failing because of an too old compiler :( |
|
@sindresorhus What do you think? 😄 |
|
The tests now only runs in io.js 1.4.1 and above since that was the version that introduced |
LinusU
changed the title
|
Really cool idea, but I don't want to introduce a native dependency. Native dependencies in Node are horrible and prone to break in so many ways and never works on Windows. Seeing how I'm planning to use this in most of my modules, I really don't want a native dependency in there. |
|
I encourage you to make this into an alternative module for those willing to have a native dependency, though. |
|
Sounds like a good plan, I'll try and finish up the other pull request then :) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws the error as soon as it's clear that it won't be handled in any way \o/