Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename camelcase to camelCase #151

Merged
merged 3 commits into from May 12, 2020
Merged

Rename camelcase to camelCase #151

merged 3 commits into from May 12, 2020

Conversation

ulken
Copy link
Contributor

@ulken ulken commented May 10, 2020

Extreme nitpick, but to my knowledge camelcase is spelled camel case and thus camelCase in code. Aligns better with its definition too 馃槣.

@ulken
Copy link
Contributor Author

ulken commented May 10, 2020

Totally unrelated, but opening a new PR felt like too much:

I find the comments

meow/index.js

Line 198 in d963c1f

// Get a list of missing flags that are required
and

meow/index.js

Line 201 in d963c1f

// Print error message for missing flags that are required
superfluous. Reading the code tells me exactly that.

If you agree, I can remove them.

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@sindresorhus
Copy link
Owner

I agree about the comments.

@ulken
Copy link
Contributor Author

ulken commented May 11, 2020

Sure. Will do tonight. And remove comments.

@ulken
Copy link
Contributor Author

ulken commented May 11, 2020

@sindresorhus Done

@ulken ulken mentioned this pull request May 11, 2020
Merged
@sindresorhus sindresorhus merged commit 20f6e85 into sindresorhus:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ulken @sindresorhus