New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flag.default values validation #238

Merged

sindresorhus merged 1 commit into sindresorhus:main from istandre:fix-default-values-validation

May 4, 2023

Contributor

istandre commented May 3, 2023 •

edited

Fixes #239
This fixes the validation of the default values.

Example:

meow({
	importMeta,
	flags: {
		string: {
			type: 'string',
			choices: ['dog', 'cat', 'unicorn'],
			default: 'unicorn',
		},
	},
});

should not throw an error, since 'unicorn' exists within the option choices.

But instead, it throws the following error:

Each value of the option `default` must exist within the option `choices`. Invalid flags: `--string`.


          Fix flag.default values validation

f5912f6

sindresorhus merged commit c3bf62b into sindresorhus:main

3 checks passed

Owner

sindresorhus commented May 4, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment