Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup for #93, this is a simpler change that makes
loudRejection
optional to allow users to define their own handling for uncaught rejections.Without this, adding a user-defined handler that throws the exception in order to crash the process (i.e.
process.on('unhandledRejection', err => { throw err })
) could result in the log message appearing twice, depending on which handler gets registered first.This is also the case with
hard-rejection
: enabling it after callingmeow()
results in two error messages, enabling it beforemeow()
works as expected, which is somewhat of a confusing behavior.