Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loudRejection optional #94

Closed
wants to merge 1 commit into from
Closed

Conversation

shesek
Copy link

@shesek shesek commented Jul 18, 2018

As a followup for #93, this is a simpler change that makes loudRejection optional to allow users to define their own handling for uncaught rejections.

Without this, adding a user-defined handler that throws the exception in order to crash the process (i.e. process.on('unhandledRejection', err => { throw err })) could result in the log message appearing twice, depending on which handler gets registered first.

This is also the case with hard-rejection: enabling it after calling meow() results in two error messages, enabling it before meow() works as expected, which is somewhat of a confusing behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant