-
Notifications
You must be signed in to change notification settings - Fork 0
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop License
section in readme?
#3
Comments
Having a separate section for License creates redundant information in the repository. But removing license from the repo can affect for users referring a repo offline. I guess they have created it to have a better view of the repository (a summary) when a user visits a repo on GitHub, |
The license file will still be present. He is referring to the I'm not entirely sure about it though. It's also a section that shows the author of the lib. I rather have it like it is now then adding a |
Agreed that a user can still go to LICENSE file and read the license information, but a user can read that upfront if that information is still present in readme. |
@tHBp This issue is about mine and my friends repos, which all use the MIT license that is easily detected. |
Personally I've always find having the license referenced in the readme is nice when you pull projects down from NPM, easier reference than opening the license itself. It also notifies a user that might otherwise ignore the license completely and possibly misuse the licensed software - I'll be keeping the license referenced in all my projects just as a simple helper |
@hhsnopek The argument being made here is that because the package.json file has a field for the license, you can just figure out the license from there instead of having it be in the README. |
@SEAPUNK right, but assume we have an edge case where a project isn't on NPM or has nothing similar to a |
Even if the project isn't on NPM, it usually has a package.json file in the repo, for dependencies and such.. unless we're no longer talking about node.js/javascript projects in specific. |
Again I'm talking edge cases - but that would be my reference :) |
It still has the license defined in package.json and the |
@sindresorhus I think if just having just a |
@hhsnopek I personally only had the |
@sindresorhus considering that, I think you answered your own question 😀 |
@hhsnopek Yes, I'm aware of my own reasoning. I opened this issue as I'm curious what others think. Maybe they would present some valid use-cases of why it should be kept. |
I don't have any reason to keep the license in the readme, unless the license is a modified Frankenstein that GitHub would not pick up. |
Sindre stated before
|
I would keep it, personally.
|
Ok, I'll leave it. Thanks for the feedback all 🤗
You should report that to GitHub. They have the exact same license file. |
I played a bit with the license file and found a possible explanation: After launching the feature the license was shown correctly in the status bar. There probably was a change later that requires a year in the license file. When pushing a new license only those containing a year will be identified and shown. A license file starting with the following lines works fine for me:
|
GitHub now shows the license in the repo summary. So there's no longer much value of having it in the readme. npmjs.com already shows the license defined in package.json. And users reading the readme offline can just check the license file.
Thoughts?
The text was updated successfully, but these errors were encountered: