Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minified version with gulp and removed duplicate html styling #12

Closed
wants to merge 1 commit into from

Conversation

ixahmedxi
Copy link

I added gulp and created a task to minify the css file, the file not minified is 8kb on disk while the minified version is half that size with only 4kb size on disk. I've also noticed a duplicate html styling in the file and merged the two properties into one for better code organization.

Just a question, should I create a scss or stylus versions with variables so anyone could adjust the styling to their needs, how about mixins that could be used just when the user needs to normalize that part, for example if I am not going to use any code tags in my website it would be better to not load the normalizing styles for the code tag, right?

@sindresorhus
Copy link
Owner

I appreciate the PR, but I'm not interested in having a build-step here. See my comment in #9 (comment).

@sindresorhus
Copy link
Owner

for example if I am not going to use any code tags in my website it would be better to not load the normalizing styles for the code tag, right?

We're talking just a few bytes. Not worth doing anything extra to avoid that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants