New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceptance tests #35
Add acceptance tests #35
Conversation
We need to figure out a way to test in safari. Maybe using BrowserStack? @sindresorhus @Zirro |
Travis supports |
Worked like a charm |
There are some future issues:
Even so, everything seems to be alright. @sindresorhus @Zirro |
Why are there duplicate test files for each browser? |
Each browser has it's own style property values, like some line-heights and vendor properties (-webkit-appearance, -webkit-text-size-adjust, -moz-tab-size). What's more, we need to run some assertions that is valid only in one browser, like "Remove the inner border and padding in Firefox.", that does not even exists on chrome and safari (-moz-focus-inner). I've sepparated the tests into two types. The I would really appreciate some feedback and improvements. It was troublesome to test some scenarios like safari's font on different platforms (my pc vs travis mac). 😁 |
@rafaelfbs Sorry for leaving this for so long. I just had to many PRs to review. Can you fix the failing tests? |
@sindresorhus Tests passing. |
Looking good. Thanks for working on this ❤️ |
A starting point to create acceptance tests and to validate outdated styles (will close #1, close #22)
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor