Use single quotes for quoted text in comments instead of backticks #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-lock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS-in-JS is becoming wildly popular for styling client-side web applications.
A number of the tools/frameworks for styling in Javascript utilize template literals to allow for real css syntax, as opposed to styles written in javascript objects. Styled Components is probably the most popular example.
Since template literals use backticks, parsing css which contain backticks within comments is problematic, causing linting/parsing errors.
In order to copy-paste
modern-normalize.cssdirectly into one of these frameworks, we can simply use single quotes instead of backticks inside of the comments.If it makes no difference otherwise (and maybe it does, please correct me if so), then why not? ;)