Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the logo to dark mode #59

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

spacedawwwg
Copy link
Contributor

@spacedawwwg spacedawwwg commented Jan 20, 2022

image

@sindresorhus
Copy link
Owner

It doesn't seem to work when I look at https://github.com/spacedawwwg/modern-normalize/blob/patch-2/readme.md in dark mode.

@spacedawwwg
Copy link
Contributor Author

image

@sindresorhus
Copy link
Owner

Go to https://github.com/spacedawwwg/modern-normalize/tree/patch-2 when in dark mode, and then change the system to light mode. The text does not update. It only updates after a page refresh.

@spacedawwwg
Copy link
Contributor Author

spacedawwwg commented Jan 23, 2022

@sindresorhus that's a known bug with chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1093736

This would at least offer users who visit while already in dark mode a better experience.

@sindresorhus sindresorhus changed the title Logo dark mode support Adapt the logo to dark mode Jan 24, 2022
@sindresorhus sindresorhus merged commit b59ec0d into sindresorhus:main Jan 24, 2022
@sindresorhus
Copy link
Owner

Thanks :)

@JoCat
Copy link

JoCat commented May 23, 2023

There is one problem, this edit does not take into account the following use case: with a light theme on the github and a dark theme in the system and vice versa. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants