Preserve input order for the returned matching paths #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The behavior needs to be documented in the readme and index.d.ts. |
sindresorhus
requested changes
Feb 14, 2020
|
@ThanveerulHuq Friendly bump :) |
|
@sindresorhus Added changes based on PR comment |
sindresorhus
requested changes
Jul 12, 2020
⬆️ |
added 2 commits
August 23, 2020 13:16
result moved closer to the for loop
|
@sindresorhus commented issues fixed and added documentation in readme and index.d.ts |
sindresorhus
reviewed
Sep 3, 2020
index.d.ts
Outdated
| @@ -9,7 +9,7 @@ Extends [`minimatch.match()`](https://github.com/isaacs/minimatch#minimatchmatch | |||
|
|
|||
| @param paths - Paths to match against. | |||
| @param patterns - Globbing patterns to use. For example: `['*', '!cake']`. See supported [`minimatch` patterns](https://github.com/isaacs/minimatch#usage). | |||
| @returns The matching paths. | |||
| @returns The matching paths in the order input paths. | |||
sindresorhus
reviewed
Sep 3, 2020
|
The PR could use a better title. |
added 2 commits
September 3, 2020 20:49
sindresorhus
reviewed
Oct 4, 2020
sindresorhus
reviewed
Oct 4, 2020
added 2 commits
October 6, 2020 14:15
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve list ordering with multiple patterns #14 issue fixed
Fixes #14