Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make offline warning optional #208

Closed
brettz9 opened this issue Mar 31, 2020 · 1 comment
Closed

Make offline warning optional #208

brettz9 opened this issue Mar 31, 2020 · 1 comment

Comments

@brettz9
Copy link

brettz9 commented Mar 31, 2020

Hi,

Just starting using and this looks like a great tool!

Was wondering if, particularly for those of us on easily disrupted connections, you could make the warning icon optional? It can be a little distracting to see the red there so frequently.

Thanks!

@notlmn
Copy link
Collaborator

notlmn commented Mar 31, 2020

I live on flaky WiFi too, but the thing is that if we do not show the warning, the user does not know that they are offline, think that they do not have any notifications, and come back here to raise an issue to show them if they are offline.

When you are offline, the badge should be yellow in color, not red. Browsers sometime think that they are online, despite being offline (and vice versa), which makes us to think that the API is failing, hence rending the red color.

I'm glad you liked the extension. Happy to hear on how we can keep improving it.

@notlmn notlmn closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants