Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show list of commits before choosing version type #238

Closed
sindresorhus opened this issue Feb 13, 2018 · 1 comment · Fixed by #241
Closed

Show list of commits before choosing version type #238

sindresorhus opened this issue Feb 13, 2018 · 1 comment · Fixed by #241
Labels
enhancement help wanted

Comments

@sindresorhus
Copy link
Owner

Currently, the list of commits being included in the release shows up after you select a version type (E.g. patch). This makes the commit list less useful, as some of its usefulness is about helping you pick the correct version type.

We should either show it before the version selection or at the same time. Probably before as the commit list could be long.
@SamVerschueren
Copy link
Collaborator

Yes I agree, this would be better.

SamVerschueren added a commit that referenced this issue Feb 17, 2018
@SamVerschueren
Show list of commits before prompt - fixes #238
2c87499
@SamVerschueren SamVerschueren mentioned this issue Feb 17, 2018
Merged
SamVerschueren added a commit that referenced this issue Feb 17, 2018
@SamVerschueren
Show list of commits before prompt - fixes #238
7b11706
sindresorhus pushed a commit that referenced this issue Feb 19, 2018
@SamVerschueren @sindresorhus
Show list of commits before prompt - fixes #238 (#241)
7278d2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show list of commits before prompt - fixes #238 sindresorhus/np
2 participants
@sindresorhus @SamVerschueren