Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to use new "npm ci" during release? #285

Closed
bryantrobbins opened this issue Jul 12, 2018 · 4 comments
Closed

Possible to use new "npm ci" during release? #285

bryantrobbins opened this issue Jul 12, 2018 · 4 comments
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@bryantrobbins
Copy link

bryantrobbins commented Jul 12, 2018

Issuehunt badges

Hello,

Is is possible to use the relatively new npm ci command during the release process instead of the default "npm install"? We're attempting to do an automated release against locked package versions.

Would a "--use-ci" flag or similar make sense as a convenient way to enable this? If so, I can look into a PR for the same.

yaodingyd earned $40.00 by resolving this issue!

@sindresorhus
Copy link
Owner

From the docs:

The project must have an existing package-lock.json or npm-shrinkwrap.json.

So we can just automatically use npm ci when a package-lock or npm-shrinkwrap is present. No flag needed. It removes node_modules too, so we can remove that step when using npm.

We also need to ensure the user is using a recent npm version. I think we should just change this task to require npm v6. No reason not to use the latest npm version.

PR welcome :)

@IssueHuntBot
Copy link

@issuehuntfest has funded $40.00 to this issue. See it on IssueHunt

sindresorhus added a commit that referenced this issue Jan 3, 2019
Fixes #285 


Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@IssueHuntBot
Copy link

@yaodingyd has submitted a pull request. See it on IssueHunt

@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @yaodingyd. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

No branches or pull requests

3 participants