Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inherit option so child process stuff is piped to console in real time. #30

Closed
jamestalmage opened this issue Jun 6, 2016 · 10 comments

Comments

@jamestalmage
Copy link
Contributor

execa should honor the inherit option (if not, it should).

It's annoying not to be able to see what is happening.

@sindresorhus
Copy link
Owner

👍

@SamVerschueren
Copy link
Collaborator

Yes it's really annoying. Sometimes it looks like it's hanging but it's just installing the npm dependencies. Another option would be to show a checklist and use log-update to mark "tasks" as completed.

  • Installing dependencies
  • Running tests
  • Update version
  • Publishing package
  • Pushing tags

We could also use elegant-spinner in front of the task it is executing to indicate it is busy.

So after installing the dependencies and running the tests, the list would off course look like

  • Installing dependencies
  • Running tests
  • Update version
  • Publishing package
  • Pushing tags

It's just a suggestion to create a nice looking UX.

@sindresorhus
Copy link
Owner

@SamVerschueren Good idea!

@jamestalmage
Copy link
Contributor Author

jamestalmage commented Jun 7, 2016

Instead of elegant-spinner, I would like to see the most recent line / lines of the child process.

@sindresorhus
Copy link
Owner

why-not-both

@jamestalmage
Copy link
Contributor Author

Yeah sure.

@sholladay
Copy link
Contributor

sholladay commented Jun 10, 2016

Nothing npm prints is very useful. E.g. while I do care about my dependency tree, at install time I don't give a damn what the sub-sub-sub dependencies are of my dependencies. And I am never going to read that.

Man I need that checklist with a spinner in my life.

@SamVerschueren
Copy link
Collaborator

Did the first step already: https://github.com/SamVerschueren/listr. Have implemented it in np and will do a PR one of the following days.

@jamestalmage
Copy link
Contributor Author

The only reason I want what npm prints, is to know if it has hung.

The progress bar is nice as well.

Also, when I'm installing something that has a long build step as part of it's install (i.e. phantomjs-prebuilt), I want to see what's causing the hold up.

@sindresorhus
Copy link
Owner

I added some quick logging in the meantime: 445924f (@Hypercubed fyi)

And a new version is out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants