Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np supports Node 8 but new dependency new-github-release-url supports Node 10 #340

Closed
brandonweiss opened this issue Jan 23, 2019 · 2 comments

Comments

@brandonweiss
Copy link

I noticed the build failing on a package of mine that supports Node 8 when trying to update np from 3.1.0 to 4.0.x. The problem seems to be that although np supports Node 8 and higher new-github-release-url supports Node 10 and higher. So when Travis CI tries to test my package on Node 8 it fails trying to install devDependencies, which contains np.

Am I thinking about this wrong? It seems like np can’t depend on a package that has a stricter Node version requirement than itself?

@voxpelli
Copy link
Contributor

@brandonweiss You are absolutely right I would say and I added a PR that helps test this and ensure that errors like these are caught.

I didn't include a bump of the engine version as I'm unsure how @sindresorhus would prefer to solve this.

@brandonweiss
Copy link
Author

@sindresorhus Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants