Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check package.json engine version range #341

Closed
wants to merge 1 commit into from
Closed

Check package.json engine version range #341

wants to merge 1 commit into from

Conversation

voxpelli
Copy link
Contributor

When running the tests, also check and ensure that the package.json engine version range for node isn't more permissive than that of its dependencies

Catches problems like #340

Uses my installed-check module with flags to not include dev dependencies in the check (-d), check the engine version range (-e) and not do the default behavior of checking whether installed modules matches the required version ranges defined in the package.json (-n)

This is expected to fail until the issue mentioned in #340 has been fixed, as this is a test to catch that error

Ensure that it isn't more permissive than that of its dependencies

Catches problems like #340
@sindresorhus
Copy link
Owner

I appreciate the PR, but I don't want more tooling in my repos. This is also the first time I have ever had this problem in 1000+ packages in 7 years, so I'm willing to take risk. That being said, I can imagine this could help other package maintainers, how about we integrate the engine check in np as a prerequisite check?

@voxpelli
Copy link
Contributor Author

@sindresorhus That sounds like a neat idea, I like it and I understand your point of view.

I'll look into it and will create a new PR 👍

@sindresorhus
Copy link
Owner

Great! Would be nice if you could split out the CLI part of installed-check into a separate package to reduce the amount of (moot) dependencies. See: sindresorhus/ama#17

@voxpelli
Copy link
Contributor Author

@sindresorhus An update: I have done an initial split @ https://github.com/voxpelli/node-installed-check-core and I will pick it it up after my current deadlines

@voxpelli voxpelli deleted the validate-engine-version branch July 25, 2020 21:05
@voxpelli voxpelli restored the validate-engine-version branch July 25, 2020 21:05
@voxpelli voxpelli deleted the validate-engine-version branch July 25, 2020 21:05
@voxpelli voxpelli restored the validate-engine-version branch July 25, 2020 21:05
@voxpelli voxpelli deleted the validate-engine-version branch July 25, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants