New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to set branch name? #58
Comments
Set a branch name for what exactly? |
I think he's asking for the ability to set a config where releases must be performed from the |
Thanks @jamestalmage ! Yeah... I tend to use |
I see two simple solutions to this.
|
I would be ok with |
as I tend to use |
Note that the 2nd option suggested in #58 (comment) has already been implemented in #354. |
I implemented My reasoning at the time was:
That said, |
yeah, in the spirit of that keeping simplicity principle, i was going to just suggest supporting a few well-known keys, such as "release" and "latest" and "current", and to do some light amount of probing to make sure that there was only one of these release-named branches. But as a configuration option has been proposed here, it seems reasonable to propose a configuration based PR. |
@forivall I don't think we should add support for specific branch names other than
The option I'd go with is
@sholladay If we go with |
I think we should add I think
Those users can continue to use
I think keeping |
The idea for a wildcard kind of plays into why I didn't want to have a For people who would use this feature, it's probably to be used in a larger release script. And I think those people should just do I could see more of a benefit if the feature actually did the All that said, |
We'll just clearly document that for anything else other than setting a static branch name, people should just use |
Opened a PR that should address this: #476 @sholladay your point around it spiralling is a really good one (and of it being fairly limited in use). My need for it was specifically around the fact that we use release as the name of all of our default branches rather than master and I didn't want to have to wrap np up in anything in order to be able to use it. (just read @howardroark original comment on this and it's the same reason 🙌) |
I've started hitting this since some of the projects I work on have switched to a |
Yep, I just ran into this, as we have switched away from |
Yeah I think so. The feature is documented in the config section of the readme for anyone that needs it. @cspotcode and @ckknight - theres a |
@sindresorhus this issue can be closed as well |
This looks great! Would entertain the option to set the branch name? I like to use
release
vsmaster
.The text was updated successfully, but these errors were encountered: