Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if tag already exists before publishing #70

Closed
ianstormtaylor opened this issue Jul 22, 2016 · 4 comments
Closed

Check if tag already exists before publishing #70

ianstormtaylor opened this issue Jul 22, 2016 · 4 comments

Comments

@ianstormtaylor
Copy link

If the Git tag for the version already exists, np will fail, but only after bumping the version in the package.json and pushing a new commit to master.

@sindresorhus
Copy link
Owner

Yes! That has happened to me multiple times before. Should really be fixed in npm version, but I doubt anything will happen there, so we can fix it here. What should happen if the tag already exists? I assume you want it to fail in the Prerequisite check?

@ianstormtaylor
Copy link
Author

Yup, I think failing as early as possible if it already exists sounds good!

@SamVerschueren
Copy link
Collaborator

Definitely a good idea!

@sindresorhus
Copy link
Owner

I opened an npm issue for this so it can be fixed there eventually: npm/npm#13660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants