Skip "Ping npm registry" task when using --no-publish
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip the task 'Ping npm registry' when the option `--no-publish` is present on the command line, as this task is only useful when publishing a package. I tried to run `np --no-publish` with a custom npm registry ([Nexus](https://help.sonatype.com/display/NXRM3/Node+Packaged+Modules+and+npm+Registries)) set in `~/.npmrc` and this fails without this patch as it tries to ping the npm registry, which is unfortunately [not supported on Nexus](https://issues.sonatype.org/browse/NEXUS-13434).
| @@ -12,7 +12,7 @@ module.exports = (input, pkg, opts) => { | |||
| const tasks = [ | |||
| { | |||
| title: 'Ping npm registry', | |||
| skip: () => pkg.private || isExternalRegistry, | |||
| skip: () => pkg.private || isExternalRegistry || !opts.publish, | |||
There was a problem hiding this comment.
It needs to be handled in the other npm prerequisite tasks too.
There was a problem hiding this comment.
now also done for
- Verify user is authenticated
- Check npm version
prerequisite tasks
* Verify user is authenticated * Check npm version
|
Why not use So many |
sindresorhus
changed the title
--no-publish
sindresorhus
added a commit
that referenced
this pull request
May 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the task 'Ping npm registry' when the option
--no-publishispresent on the command line, as this task is only useful when publishing
a package.
I tried to run
np --no-publishwith a custom npm registry (Nexus) set in~/.npmrcand this fails without this patch as it tries to ping the npm registry, which is unfortunately not supported on Nexus.