Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn version bump for private packages #257

Merged

Conversation

tusbar
Copy link
Sponsor Contributor

@tusbar tusbar commented Apr 10, 2018

This allows np to create a tag on a private package, it sort of reverts #235.
For public packages, the tag will be created using yarn publish.

Private package:

$ ../np/cli.js 1.0.1
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies using Yarn
 ✔ Running tests using Yarn
 ✔ Bumping version using Yarn
 ↓ Publishing package using Yarn [skipped]
   → Private package: not publishing to Yarn.
 ✔ Pushing tags

Public package:

$ ../np/cli.js 1.0.2
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies using Yarn
 ✔ Running tests using Yarn
 ↓ Bumping version using Yarn [skipped]
   → Public package: version will be bumped using yarn publish.
 ✔ Publishing package using Yarn
 ✔ Pushing tags

cc @gpoole @ErisDS

This allows np to create a tag on a private package, it sort of reverts
sindresorhus#235.
For public packages, the tag will be created using yarn publish.
@gpoole
Copy link

gpoole commented Apr 10, 2018 via email

@tusbar
Copy link
Sponsor Contributor Author

tusbar commented May 20, 2018

@sindresorhus could you take a look at this? :)

@sindresorhus sindresorhus merged commit 1479d15 into sindresorhus:master May 21, 2018
@tusbar tusbar deleted the tusbar/fix-yarn-version-bump branch May 22, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants